fix(flow): rename src/index.js to src/gymnast.js #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arahansen
changed the title
arahansen
force-pushed
the
arahansen/fix-flow
branch
from
89e5b6a to
cb75f45
Compare
Since webpack outputs a file called `gymnast.js`, the src file needs to be named the same so that when we output flow files, we get `gymnast.js` (webpack output) next to `gymnast.js.flow` (flow types generated from src). Alternatively, we could update webpack to output a file named `index.js.
arahansen
force-pushed
the
arahansen/fix-flow
branch
from
cb75f45 to
f29f19d
Compare
arahansen
commented
Feb 23, 2018
| @@ -14,7 +14,7 @@ | |||
| [libs] | |||
|
|
|||
| [options] | |||
| module.name_mapper='gymnast' -> '<PROJECT_ROOT>/src' | |||
| module.name_mapper='gymnast' -> '<PROJECT_ROOT>/dist/gymnast' | |||
There was a problem hiding this comment.
This should hopefully give us a better confidence that flow types are working correctly
obartra
approved these changes
Feb 23, 2018
|
🎉 This PR is included in version 16.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since webpack outputs a file called
gymnast.js, the src file needs to be named the same so that when we output flow files, we getgymnast.js(webpack output) next togymnast.js.flow(flow types generated from src).Alternatively, we could update webpack to output a file named
index.js.